Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move enum Chip from fwidgen to hubtools lib. #45

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

flihp
Copy link
Contributor

@flihp flihp commented Mar 20, 2025

We do some work here to preserve the existing behavior of the is_lpc55 function to keep from breaking API compatibility.

this resolves #39

@flihp flihp requested review from labbott and lzrd March 20, 2025 18:04
Copy link
Contributor

@lzrd lzrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move more code into hubtools (see newly created Issue 51). But that work could be left for a later refactor without blocking this PR.

We do some work here to preserve the existing behavior of the `is_lpc55`
function to keep from breaking API compatibility.
@flihp flihp force-pushed the chip-enum-to-hubtools branch from 0e27c09 to 1cfcec0 Compare March 25, 2025 20:17
@flihp flihp merged commit 8a66b29 into oxidecomputer:main Mar 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chip abstraction
3 participants