Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to derive Clone on RawHubrisArchive for faux-mgs work. #36

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Need to derive Clone on RawHubrisArchive for faux-mgs work. #36

merged 1 commit into from
Mar 12, 2025

Conversation

lzrd
Copy link
Contributor

@lzrd lzrd commented Mar 12, 2025

Derive Clone on RawHubrisArchive to make it a bit more useful.

@lzrd lzrd requested a review from mkeeter March 12, 2025 02:47
@lzrd lzrd enabled auto-merge (squash) March 12, 2025 02:47
@lzrd lzrd merged commit f149bc1 into main Mar 12, 2025
1 check passed
@mkeeter
Copy link
Collaborator

mkeeter commented Mar 12, 2025 •
edited
Loading

Why is this necessary? In general, I don't like deriving Clone on types which own large amounts of data; needing to clone a Vec<u8> is usually a sign that you should be passing a reference instead.

Also, what isfaux-mgs going to be doing with the RawHubrisArchive? It shouldn't be doing any archive introspection, except for the update workflows.

@lzrd
Copy link
Contributor Author

lzrd commented Mar 14, 2025

This is needed for some Rhai scripting work.

@lzrd lzrd deleted the clone-on-raw-hubris-archive branch March 18, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeter mkeeter Awaiting requested review from mkeeter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lzrd @mkeeter