Add HubrisArchiveBuilder to create hubris archives from raw images or thin air
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
labbott
approved these changes
Aug 16, 2023
mkeeter
reviewed
Aug 17, 2023
mkeeter
reviewed
Aug 17, 2023
mkeeter
approved these changes
Aug 17, 2023
jgallagher
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 17, 2023
…t hardware revisions) (#3887) This PR also teaches tufaceous-lib how to generate fake hubris artifacts that look like real hubris archives (at least up to having a valid caboose), via the not-yet-merged `HubrisArchiveBuilder` from `hubtools`. There are a couple things I need to do before merging this PR: - [x] Update `hubtools` in Cargo.toml once oxidecomputer/hubtools#19 lands - [x] Test on madrid with a manually-built repo with multiple SP images but I think it's close enough it can be reviewed. Fixes #3394.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My immediate goal with this is to be able to generate fake hubris archives for integration tests in omicron, and as of this PR
HubrisArchiveBuilderis probably only useful for that. I tried not to close the door on it potentially being useful to generate a real hubris archive from a standalone image, but it will need some additions for that to be useful (e.g., adding anapp.tomlfor humility).