Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chip abstraction #39

Closed
flihp opened this issue Mar 18, 2025 · 0 comments · Fixed by #45
Closed

chip abstraction #39

flihp opened this issue Mar 18, 2025 · 0 comments · Fixed by #45

Comments

@flihp
Copy link
Contributor

flihp commented Mar 18, 2025

The fwidgen tool duplicates a lot of the is_lpc55 function from the RawHubrisArchive type. This tool needs to differentiate between lpc55 & stm32 chips but adding an is_stm32 function didn't feel right. We'd prefer an abstraction, something like the Chips enum from the fwidgen tool that can TryFrom<RawHubrisArchive> for all supported chips. This will however change the hubtools API so we left this as future work in #38. Ideally we'd depricate the is_lpc55 function, but we could remain backward compatible by using the enum behind the scenes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant