Make ImpactedBlocks an absolute range
#1685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faithanalog
added a commit
that referenced
this pull request
Mar 19, 2025
Only remaining usage after #1685 was for tests, in precisely one function. Now that's gone, and the tests don't do unnecessary conversions between (extent, block) and absolute address anymore.
faithanalog
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
ImpactedBlocksstores an inclusive range ofImpactedAddr, which are themselves(ExtentId, BlockOffset)tuples. This makes life awkward, because we don't know how to step through a range ofImpactedBlockswithout knowing the blocks-per-extent count: is(ExtentId(0), BlockOffset(7))adjacent to(ExtentId(1), BlockOffset(0))? Without additional information, there's no way of knowing!This ambiguity adds a bunch of boilerplate, and specifically complicates the implementation of
ActiveJobs.The only time when we actually need the extent ID is when doing live-repair activities, which forgo the block abstraction and care about individual extent files. It makes much more sense to have
ImpactedBlocksbe an absolute block range (usingBlockIndexinstead ofBlockOffset), then tweak the small number of sites which care about extents. These sites are:Downstairs::reserve_repair_ids_for_extentDownstairs::get_repair_idsDownstairs::check_repair_ids_for_rangeActiveJobs::deps_for_repairImpactedBlocks::extents