Remove unnecessary argument #1672
Merged
+4
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpesp
approved these changes
Mar 17, 2025
mkeeter
added a commit
that referenced
this pull request
Mar 18, 2025
`Downstairs::begin_repair_for` had confusing semantics: it was used to both start live-repair (setting `self.repair` to `Some(..)`) _and_ to send subsequent jobs. Most of its arguments were only used in one or the other case. This PR splits it into three functions: - `start_live_repair` initializes `self.repair` and sends the first live-repair IO - `send_next_live_repair` sends the next live-repair IO - Under the hood, both of these functions call `send_live_repair_jobs` to reserve repair IDs and actually send IO In passing, I also removed the `extent_count` argument from `notify_live_repair_progress`, since it can be computed locally (basically just pushing the change from #1672 further down the call stack).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Downstairsalready has the region definition available locally, so we don't need to pass in the extent count.