Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alan and I were talking in person about pending work tracking in the Downstairs, and I found some room for simplification:
struct PendingJob
HashMap<JobId, IOop>
then cloning + sorting the keys to make aVec<JobId>
, just use aVecDeque
This are relatively small cleanups, but may have a small impact on Downstairs RAM usage.
There are two behavior changes, both of which should be innocuous:
JobId
then checking whether they're ready. This is fine, because readiness is determined by dependencies.show_work
debug function no longer sorts job IDs when printing pending work