Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize dummy downstairs tests #1253

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Reorganize dummy downstairs tests #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6d7cdcd
Add Guest fn and BlockOp to get downstairs state
mkeeter Apr 9, 2024
d7ee8f0
Add some helper functions
mkeeter Apr 9, 2024
4ada813
Fix comment
mkeeter Apr 9, 2024
3274857
More comment fixes
mkeeter Apr 9, 2024
b49f8a5
More cleanup
mkeeter Apr 9, 2024
c172e0d
More consolidation
mkeeter Apr 9, 2024
3437375
Remove unused vars
mkeeter Apr 9, 2024
c18f0d3
Fix warnings
mkeeter Apr 9, 2024
21d9ac6
Remove comment
mkeeter Apr 10, 2024
1cc5719
Update comments / log messages
mkeeter Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions upstairs/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,6 +2337,10 @@ pub(crate) enum ClientStopReason {

/// The upstairs has requested that we deactivate
Deactivated,

/// The test suite has requested a fault
#[cfg(test)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how it would work, but it might be nice to have a way to expose this interface
as a build option? We could write various tests that would trigger a fault during specific
times. I suppose it's not much different than just stopping or pstopping a downstairs process
which is our go to method now.

RequestedFault,
}

/// Response received from the I/O task
Expand Down
Loading