Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gw_ds_complete less public #1175

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

mkeeter
Copy link
Contributor

@mkeeter mkeeter commented Feb 21, 2024

I'm a little confused by this – crucible compiles just fine, but using it in propolis-standalone gives a compile-time error message:

error[E0446]: crate-private type `GuestWorkId` in public interface
   --> /home/matt/crucible/upstairs/src/guest.rs:246:5
    |
150 | pub(crate) struct GuestWorkId(pub u64);
    | ----------------------------- `GuestWorkId` declared as crate-private
...
246 |     #[instrument]
    |     ^^^^^^^^^^^^^ can't leak crate-private type
    |
    = note: this error originates in the attribute macro `instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0446`.

@mkeeter mkeeter changed the title Make GuestWorkId public Make gw_ds_complete less public Feb 21, 2024
@mkeeter
Copy link
Contributor Author

mkeeter commented Feb 21, 2024

Update: it turns out that changing gw_ds_complete from pub to pub(crate) also resolves the issue, so let's do that instead!

@mkeeter mkeeter merged commit 23fb1dd into oxidecomputer:main Feb 21, 2024
18 checks passed
@mkeeter mkeeter deleted the public-gw-id branch February 21, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants