Added a contributing.md #1158
Merged
Added a contributing.md #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
reviewed
Feb 12, 2024
CONTRIBUTING.md
Outdated
| - Our current goal is support our first generation products. | ||
|
|
||
| - We're writing Crucible in support of that goal, not as its own thing. We're | ||
| all working on the products, and tool development is a side effect. |
There was a problem hiding this comment.
This sentence doesn't transplant well, since I don't think of Crucible as "tool development".
Maybe "We're all working on the products, and block storage is an important product feature."?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a copy of Contributing.md from other Oxide repos that I never added to Crucible.
On the eve of the 0xF storage podcast, I thought it might be good to put this out there.