A builder for the Downstairs Downstairs struct. #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the downstairs Downstairs struct to have a builder. Replaced build_downstairs_for_region() and build_downstairs_for_region_with_backend() with the new builder pattern.
jmpesp
reviewed
Feb 21, 2024
| write_errors: bool, | ||
| flush_errors: bool, | ||
| read_only: bool, | ||
| encrypted: bool, |
There was a problem hiding this comment.
how do we configure whether or not encryption is used?
There was a problem hiding this comment.
Hmm, I guess you can't any more when starting a downstairs.
The region creation itself is where the decision to have or not have encryption is made. When we start a downstairs, the opening of the region will auto-select the encryption state.
If we allow start of a downstairs to pick what encryption it has, all that will end up doing is:
1: Match what the region open finds and move forward.
2: Not match the region open, and exit with error or panic.
Do we need to have this ability in the downstairs run path?
There was a problem hiding this comment.
Definitely not, ignore my comment!
jmpesp
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a builder for the Downstairs
Downstairsstruct.Removed the
build_downstairs_for_region_with_backend()andbuild_downstairs_for_region()functions as they are no longer needed.