Simplify the do_work_task loop
#1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftwo
approved these changes
Feb 7, 2024
| is_flush, | ||
| ) | ||
| .await?; | ||
| cdt::work__process!(|| job_id.0); |
There was a problem hiding this comment.
I thought maybe this probe was in a bad spot, as we could hit this, then
fal out of the loop if some other downstairs was promoted at line 1057,
but, if that really is the case, then the whole accounting is meaningless
as we should be shutting this task down with the other upstairs takes over.
Also, this issue was here before you refactored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VecDequeto remove the inner / outer loopsis_lossyconditional helps exercise reordering / dependency trackinglet Some(v) = v else { continue; };pattern to reduce rightward indentation creepcheck_message_for_abortnext to the code that actually handles errors + replyingThis is mostly indentation changes by volume; sorry that the Github UI is Very Mad about it.