Move Guest stuff into a module
#1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftwo
approved these changes
Feb 6, 2024
upstairs/src/guest.rs
Outdated
| @@ -0,0 +1,1417 @@ | |||
| // Copyright 2023 Oxide Computer Company | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents us from directly messing with internals, improving system modularity.
(it's secretly a building block for later improvements to backpressure, but stands alone as a reorganization PR)
Things moved include
struct Guest(still republished at the crate root to avoid breaking dependencies)struct GuestWorkstruct GuestIoHandlestruct GuestWorkIdstruct GtoS(now private, since it's an implementation detail ofGuestWork)struct BackpressureConfigThere should be no logical changes, just a bunch of reorganization + adding small functions to replace direct poking of
GuestIoHandle/GuestWorkinternals. One notable addition isGuestWork::submit_job, which consolidates a common sequence of "get nextGuestWorkId, use it to get aJobId, use that to build aGtoS, insert it into theGuestWorkmap".