Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crdb-harness #75

Merged
merged 2 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ jobs:
steps:
# actions/checkout@v2
- uses: actions/checkout@9a9194f87191a7e9055e3e9b95b8cfb13023bb08
- name: Download CockroachDB
run: ./tools/ci_download_cockroachdb
- name: Add CockroachDB to PATH
run: echo ./out/cockroachdb/bin >> $GITHUB_PATH
- name: Build
run: cargo build --tests --verbose
- name: Run tests
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ tokio = { version = "1.32", default-features = false, features = [ "rt-multi-thr

[dev-dependencies]
anyhow = "1.0"
crdb-harness = "0.0.1"
diesel = { version = "2.2.2", features = [ "postgres", "r2d2" ] }
libc = "0.2.154"
tempfile = "3.8"
Expand Down
12 changes: 2 additions & 10 deletions tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,5 @@
This directory includes some integration tests, specifically with the
CockroachDB database, which uses a PostgreSQL protocol.

Tests expect that the CockroachDB binary exist, and fail without it.

To download a local copy of CockroachDB:

```bash
./tools/ci_download_cockroachdb
```

This downloads a binary to `./out/cockroachdb/bin/cockoach`. If you'd like
to use your own binary here, replace this binary with your own executable.
These tests rely on the `crdb-harness` crate to download CockroachDB
at a particular version.
Loading
Loading