Fill in Genoa tokens #120
Fill in Genoa tokens #120
Conversation
…isted under wrong data types.
|
|
||
| // Fch | ||
|
|
||
| #[cfg_attr(feature = "serde-hex", serde(serialize_with = "SerHex::<StrictPfx>::serialize", deserialize_with = "SerHex::<StrictPfx>::deserialize"))] | ||
| FchConsoleOutMode(default 0, id 0xddb7_59da) | pub get u8 : pub set u8, | ||
| FchConsoleOutMode(default 0, id 0xddb7_59da) | pub get FchConsoleOutMode : pub set FchConsoleOutMode, |
There was a problem hiding this comment.
Ok I'm all for that but what will happen to existing config files? Are they backward compatible? If not, let's make them backward compatible (that's why there's an extra serializers.rs in the first place--to be able to do that). Otherwise, we need a flag day.
There was a problem hiding this comment.
I'm in favour of revving the version and having a flag day. Especially if we do end up making some API changes. Either way this PR is just into the issue-110 working branch. Once we're ready to land to main we can update pinned commit in helios and AHIB
| // TODO: Maybe should be called `FchI2cSdaRxHold` but that's already a WordToken | ||
| FchIcSdaRxHold(default 0, id 0xa4ba_c3d5) | pub get u8: pub set u8, | ||
| // Same as `FchI2cSdaHoldOverrideMode` but that's already a WordToken | ||
| FchI2cSdaHoldOverrideMode2(default 0, id 0x545d_7662) | pub get FchI2cSdaHoldOverrideMode : pub set FchI2cSdaHoldOverrideMode, |
There was a problem hiding this comment.
If we wanted to we could totally remove (or complicate) the direct token interface that "takes all the tokens, and for each of them, generates an accessor at the top level with just the token name".
I don't think we have any consumers of that interface anyway.
Not sure what AMD's intention here is. Is it so everyone requires hungarian notation to make sense of the things? ;P
There was a problem hiding this comment.
I opened #121 to track what to do there and updated the TODO comments.
A rough pass at adding the APCB tokens found in Genoa