113 Add Permissive Serializer. #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daym
force-pushed
the
issue-113
branch
6 times, most recently
from
25f15cf to
53abcb5
Compare
daym
force-pushed
the
issue-113
branch
7 times, most recently
from
74efaeb to
45753d3
Compare
dancrossnyc
reviewed
Jan 23, 2024
|
I'm not an effective reviewer for serde black magic, sorry. Your other requested reviewers are highly capable so please don't wait on me to complete this work and get it tested and integrated. |
|
My earlier comment (about lint warnings) stands; probably best to rebase this and fix those up and then it will be ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the serializer fails on the first invalid field value it finds.
This isn't nice for bringup of new generations where we usually have (a few) unknown values on some fields and then the entire serializion will fail--and what do we do then?
Better to have the serializer just warn on fields that have unknown values and then leave those fields off the json output.
Since serde already supports
skip_serializing_if, let's just skip on error. Users then can override *Serializer'sskip_fieldand figure out when skipping happened and infer that that was because of an error.