Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip fix if cache is successful (not if failure) #62

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Skip fix if cache is successful (not if failure) #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e34bc75
Ok if success
noizwaves Feb 14, 2024
67dd1dc
Fix test
noizwaves Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scope/src/doctor/check.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ impl DefaultDoctorActionRun {
async fn evaluate_checks(&self) -> Result<CacheResults, RuntimeError> {
if let Some(cache_path) = &self.action.check.files {
let result = self.evaluate_path_check(cache_path).await?;
if !result.is_success() {
if result.is_success() {
return Ok(result);
}
}
Expand Down
2 changes: 1 addition & 1 deletion scope/tests/integration_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ fn test_run_setup() {
.assert();

result.success().stdout(predicate::str::contains(
"Check initially failed, fix was successful, group: \"setup\", name: \"1\"",
"Check was successful, group: \"setup\", name: \"1\"",
));

working_dir
Expand Down