Fixes telemetry via http #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Between opentelemetry-otlp v0.15 and 0.16 a breaking change landed. - https://github.com/pitoniak32/opentelemetry-rust/blob/main/opentelemetry-otlp/CHANGELOG.md#v0160 - open-telemetry/opentelemetry-rust#1706 So when we upgraded to 0.27 (oscope-dev#186), we inadvertantly broke people using `SCOPE_OTEL_PROTOCOL=http`. It did not affect people using `grpc`. To maintain consistency with grpc (and compatibility with version prior to PR oscope-dev#186), we append `v1/traces` to the `SCOPE_OTEL_ENDPOINT`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between opentelemetry-otlp v0.15 and 0.16 a breaking change landed.
So when we upgraded to 0.27 (#186),
we inadvertantly broke people using
SCOPE_OTEL_PROTOCOL=http. It did not affect people usinggrpc.To maintain consistency with grpc (and compatibility with version prior to PR #186), we append
v1/tracesto theSCOPE_OTEL_ENDPOINTwhen the protocol is set tohttp.