Removed duplic #59
Removed duplic #59
Conversation
…he youtube iframe to span a bigger white space plus the hover to join community button in register
✅ Deploy Preview for aquamarine-haupia-c31c21 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
components/Community.jsx
Outdated
| @@ -18,7 +18,7 @@ const Community = () => { | |||
| </p> | |||
| </div> | |||
| <h1 className='px-5 text-3xl md:mt-10'> | |||
| Join a Large Growing Community in Town | |||
| Join a Large Open Source Growing Community in Town | |||
There was a problem hiding this comment.
@Ronniedeveloper how if we had this wording as
| Join a Large Open Source Growing Community in Town | |
| Join a Large Growing Open Source Community in Town |
There was a problem hiding this comment.
I like this suggestion 💯
| src='https://www.youtube.com/embed/oylCYRfk0NQ' | ||
| title='YouTube video player' | ||
| frameBorder='' | ||
| allow='accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture' | ||
| allowFullScreen></iframe> | ||
| </div> | ||
|
|
||
| <div className='container mx-auto mt-20 max-w-6xl mx-auto'> | ||
| <div className='container mx-auto mt-20 max-w-6xl'> |
There was a problem hiding this comment.
Thank you for catching this:clap:
| @@ -221,7 +221,7 @@ const Form = () => { | |||
| <div className='w-full flex justify-end'> | |||
| <button | |||
| type='submit' | |||
| className='mt-12 w-full md:w-36 rounded-md py-3 capitalize bg-[#5A75AB] text-white font-bold tracking-wider'> | |||
| className='mt-12 w-full md:w-36 rounded-md shadow-md hover:shadow-xl py-3 capitalize bg-[#5A75AB] text-white font-bold tracking-wider'> | |||
There was a problem hiding this comment.
Looks good...this helps us keep consistency with other buttons such as those in navbar
| @@ -3,8 +3,8 @@ | |||
| "scripts": { | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "export": "next export", | |||
There was a problem hiding this comment.
@Ronniedeveloper why are these scripts being removed?
There was a problem hiding this comment.
@Ronniedeveloper please make this adjustment and all will be well with this PR
| @@ -3,7 +3,9 @@ function experience() { | |||
| return ( | |||
| <> | |||
|
|
|||
| <h1>Experience page</h1> | |||
| <div className="container mx-9 py-4 md:mt-10 sm:mt-5"> | |||
| <h1>Experience page</h1> | |||
pages/index.jsx
Outdated
| width='560' | ||
| height='315' | ||
| height='335' |
There was a problem hiding this comment.
i still feel like we need to increase the height...
|
please resolve the conflicts this branch has with |
…f the register form
| @@ -3,8 +3,8 @@ | |||
| "scripts": { | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "export": "next export", | |||
There was a problem hiding this comment.
@Ronniedeveloper please make this adjustment and all will be well with this PR
|
Hi @Ronniedeveloper , thank you for sparing time to contribute. Much appreciated 👏 |
Removed duplicate classes from the homepage of mx-auto