Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repos: add RHEL 10.1 and 9.7 repositories #1257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thozza
Copy link
Member

@thozza thozza commented Feb 25, 2025

SSIA

/jira-epic COMPOSER-2435

Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick drive-by meta comment - should this be two PRscommits? one for the gitlab-ci stuff and one that actually adds the json files to repositores data?

[edit: sorry, meant to say commits here]

@bcl
Copy link
Contributor

bcl commented Feb 25, 2025

Do you mean two PRs or two commits? :) I'd agree with two commits.

Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to me as a single commit; splitting them doesn't add much, you'd get "add repos", "use repos".

@thozza
Copy link
Member Author

thozza commented Feb 26, 2025

Quick drive-by meta comment - should this be two PRs? one for the gitlab-ci stuff and one that actually adds the json files to repositores data?

source prep will fail if one adds repos without regenerating .gitlab-ci.yml...

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
@mvo5
Copy link
Contributor

mvo5 commented Feb 26, 2025

Quick drive-by meta comment - should this be two PRs? one for the gitlab-ci stuff and one that actually adds the json files to repositores data?

source prep will fail if one adds repos without regenerating .gitlab-ci.yml...

Thank you for splitting. I like that the auto-generated stuff is in its own commit. I also like it when the commit message explains what was run to auto-generate the things (so that a simple git log or git blame will help understand how the chanages came into existance) but AIUI this is already explained in the test/README.md already so probably no need to put here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants