Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultClassResolver should resolve classes in the default package #93

Merged
merged 1 commit into from
Dec 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/main/java/ognl/DefaultClassResolver.java
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
*/
public class DefaultClassResolver extends Object implements ClassResolver
{
private final Map<String, Class> classes = new ConcurrentHashMap<>(101);
private final ConcurrentHashMap<String, Class> classes = new ConcurrentHashMap<>(101);

public DefaultClassResolver()
{
Expand All @@ -55,8 +55,22 @@ public Class classForName(String className, Map context) throws ClassNotFoundExc
if (result != null) {
return result;
}
result = (className.indexOf('.') == -1) ? toClassForName("java.lang." + className) : toClassForName(className);
classes.put(className, result);
try {
result = toClassForName(className);
} catch (ClassNotFoundException e) {
if (className.indexOf('.') > -1) {
throw e;
}
// The class was not in the default package.
// Try prepending 'java.lang.'.
try {
result = toClassForName("java.lang." + className);
} catch (ClassNotFoundException e2) {
// Report the specified class name as-is.
throw e;
}
}
classes.putIfAbsent(className, result);
return result;
}

Expand Down
4 changes: 4 additions & 0 deletions src/test/java/ClassInDefaultPackage.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

class ClassInDefaultPackage {
public static final int CONST = 99;
}
41 changes: 41 additions & 0 deletions src/test/java/ognl/DefaultClassResolverTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
package ognl;

import junit.framework.TestCase;

public class DefaultClassResolverTest extends TestCase {

public void testClassInDefaultPackageResolution() throws Exception {
DefaultClassResolver resolver = new DefaultClassResolver();
OgnlContext context = (OgnlContext) Ognl.createDefaultContext(null,
new DefaultMemberAccess(false));
assertNotNull(resolver.classForName("ClassInDefaultPackage", context));
}

public void testEnsureClassNotFoundException() throws Exception {
DefaultClassResolver resolver = new DefaultClassResolver();
OgnlContext context = (OgnlContext) Ognl.createDefaultContext(null,
new DefaultMemberAccess(false));
try {
resolver.classForName("no.such.Class", context);
fail("Expected ClassNotFoundException as the specified class does not exist.");
} catch (Exception e) {
assertEquals(ClassNotFoundException.class, e.getClass());
assertEquals("no.such.Class", e.getMessage());
}
}

public void testEnsureClassNotFoundExceptionReportsSpecifiedName()
throws Exception {
DefaultClassResolver resolver = new DefaultClassResolver();
OgnlContext context = (OgnlContext) Ognl.createDefaultContext(null,
new DefaultMemberAccess(false));
try {
resolver.classForName("BogusClass", context);
fail("Expected ClassNotFoundException as the specified class does not exist.");
} catch (Exception e) {
assertEquals(ClassNotFoundException.class, e.getClass());
assertEquals("BogusClass", e.getMessage());
}
}

}