Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets root on context if null #337

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Sets root on context if null #337

merged 2 commits into from
Jan 4, 2025

Conversation

lukaszlenart
Copy link
Collaborator

Closes #309

@lukaszlenart lukaszlenart changed the title Adds a test case to cover comparing strings Sets root on context if null Dec 29, 2024
@lukaszlenart lukaszlenart marked this pull request as ready for review December 29, 2024 10:52
@lukaszlenart lukaszlenart force-pushed the fix/equals-null branch 7 times, most recently from 45b3aaa to 9ab1bf3 Compare December 30, 2024 16:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@lukaszlenart lukaszlenart added this to the 3.4.5 milestone Jan 4, 2025
@lukaszlenart lukaszlenart merged commit 1ef0654 into main Jan 4, 2025
4 of 5 checks passed
@lukaszlenart lukaszlenart deleted the fix/equals-null branch January 4, 2025 13:42
@davsclaus davsclaus mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.5
Development

Successfully merging this pull request may close these issues.

ognl 3.4.3 string equals bug
1 participant
@lukaszlenart