ognl 3.4.3 string equals bug

[hengyunabc]

https://github.com/hengyunabc/ognl34-bug-demo

ognl 3.4.3 result

"aaa".equals(params[0].flowAttribute.getBxApp()), result: false
"aaa" == params[0].flowAttribute.getBxApp(), result: true
params[0].flowAttribute.getBxApp().equals("aaa"), result: true

ognl 3.3.5 result

"aaa".equals(params[0].flowAttribute.getBxApp()), result: true
"aaa" == params[0].flowAttribute.getBxApp(), result: true
params[0].flowAttribute.getBxApp().equals("aaa"), result: true

[lukaszlenart]

Either using ognlContext.setRoot(advice); or Object object = Ognl.getValue(conditionExpress, advice); solves the problem. Yet I'm not able to figure it out why your example fails.

[lukaszlenart]

See the proposed fix, basically specifying root on context solves the problem, because due to changes in #204 null is returned instead.

[harawata]

Hi @lukaszlenart ,

I apologize if this misses the point, but the Javadoc of Ognl#getValue(Object, OgnlContext, Object, Class<?>) says...

The default context is set for the given context and root via addDefaultContext().

But the call to addDefaultContext() is removed from getValue() and some other methods in #193.

I too am not fully understand, but could this cause the reported behavior change?

[lukaszlenart]

@harawata good catch, thanks! I will revert back to addDefaultContext(root, context); as I cannot recall what did I remove it