Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node deletion with unidirectional optional relationship #5783

Closed
wants to merge 1 commit into from

Conversation

LucasG0
Copy link
Contributor

@LucasG0 LucasG0 commented Feb 18, 2025

Fixes #5619

  • Store unidirectional relationships within SchemaBranch
  • Then check for them while deleting a node

@LucasG0 LucasG0 changed the title Fix node deletion with unidirectional optional relationship WIP: Fix node deletion with unidirectional optional relationship Feb 18, 2025
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Feb 18, 2025
@LucasG0 LucasG0 changed the title WIP: Fix node deletion with unidirectional optional relationship Fix node deletion with unidirectional optional relationship Feb 18, 2025
Copy link

codspeed-hq bot commented Feb 18, 2025

CodSpeed Performance Report

Merging #5783 will degrade performances by 42.79%

Comparing lgu-fix-delete-peer (9b24b42) with stable (e78eeae)

Summary

❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_schemabranch_process 411.3 ms 718.9 ms -42.79%

@LucasG0 LucasG0 force-pushed the lgu-fix-delete-peer branch 3 times, most recently from deb458d to 86eebfd Compare February 19, 2025 11:29
@LucasG0 LucasG0 force-pushed the lgu-fix-delete-peer branch from 86eebfd to 9b24b42 Compare February 20, 2025 11:42
@LucasG0 LucasG0 closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Frontend error when accessing Node after deleting a related node in a relationship attribute
1 participant