Check for permissions in rel add/delete mutations #5772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5772 will not alter performanceComparing Summary
|
ajtmccarty
reviewed
Feb 18, 2025
ogenstad
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
LGTM, as Aaron says it would be good with some tests in place. If we don't have that infrastructure in place I think things might fail when we bring this back to the develop branch as some of the tests there would be setting an account_session within the context to get the event stuff to work.
gmazoyer
force-pushed
the
gma-20250217-relmutation-permissions
branch
from
3dc4af7 to
0445e5b
Compare
gmazoyer
force-pushed
the
gma-20250217-relmutation-permissions
branch
from
0445e5b to
127462d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should patch a security issue where user could add relationships between nodes without going through the permission check process.
In the add/delete relationship mutations, with this change, we identify the kinds of nodes that are involved in the mutations and infer what global and object permissions are required to mutate the nodes.