Use dedicated database session for constraint runner #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5718 will not alter performanceComparing Summary
|
ajtmccarty
approved these changes
Feb 11, 2025
| if loop and loop.is_running(): | ||
| loop.create_task(self._session.close()) | ||
| else: | ||
| asyncio.run(self._session.close()) |
There was a problem hiding this comment.
can you explain what this change does? is it so that we always clean up a session created with start_session()?
There was a problem hiding this comment.
Yes, you got the point. The other way would have been to close the session at the end of the create mutation. Not sure what people like best, and I don't have a strong opinion on this myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for initial fix in #5704