add test and changes for a relationship identifier migration #5652
Conversation
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5652 will not alter performanceComparing Summary
|
ajtmccarty
force-pushed
the
ajtm-01312025-diff-migration-tests
branch
from
82066c0 to
a842562
Compare
| path_type = ( | ||
| PathType.RELATIONSHIP_ONE | ||
| if relationship_schema.cardinality is RelationshipCardinality.ONE | ||
| if relationship.cardinality is RelationshipCardinality.ONE |
There was a problem hiding this comment.
we used to have to get the cardinality of a relationship from the schema, but now we save it on the diff
There was a problem hiding this comment.
PathType has a .from_relationship() method that would be a bit cleaner to use.
| relationship_schema = node_schema.get_relationship_or_none(name=relationship_diff.name) | ||
| if not relationship_schema and alternate_node_schema: | ||
| relationship_schema = alternate_node_schema.get_relationship_or_none(name=relationship_diff.name) | ||
| relationship_diff.label = relationship_schema.label or "" if relationship_schema else "" |
There was a problem hiding this comment.
these changes are required to handle the case when a relationship name is updated
| possible_path_directions = database_path.possible_relationship_directions | ||
| for rel_schema in relationship_schemas: | ||
| if rel_schema.direction in possible_path_directions: | ||
| return rel_schema |
There was a problem hiding this comment.
we have to use both the relationship name and identifier for uniqueness because...
- an identifier is not unique if the schema has two different relationships for inbound/outbound with the same identifier, like in the case of
parentandchildrenin a hierarchy - a name is not unique if the relationship has been renamed
| path_type = ( | ||
| PathType.RELATIONSHIP_ONE | ||
| if relationship_schema.cardinality is RelationshipCardinality.ONE | ||
| if relationship.cardinality is RelationshipCardinality.ONE |
There was a problem hiding this comment.
PathType has a .from_relationship() method that would be a bit cleaner to use.
python_sdk
Outdated
There was a problem hiding this comment.
Was the update of the python_sdk commit intentional or by accident?
There was a problem hiding this comment.
accidental. will revert it
ajtmccarty
force-pushed
the
ajtm-01312025-diff-migration-tests
branch
from
1b7aa6b to
8ebb56a
Compare
IFC-1202
add tests for the diff calculation logic when handling an attribute name migration or a relationship identifier migration.
update the diff calculation logic to correctly handle a relationship identifier migration. this required using the relationship's identifier instead of its name for determining uniqueness