Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): various performance improvements #5648

Merged
merged 6 commits into from
Feb 3, 2025

Conversation

fatih-acar
Copy link
Contributor

No description provided.

10x speed-up.
It would also consume too much memory and startup would fail when heap
size is not enough.

Signed-off-by: Fatih Acar <fatih@opsmill.com>
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jan 31, 2025
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #5648 will not alter performance

Comparing fac-stable-query-improv (f002cd2) with stable (f964cb8)

Summary

✅ 11 untouched benchmarks

It adds a significant overhead since it uses NodeGetListQuery.

Signed-off-by: Fatih Acar <fatih@opsmill.com>
Using an early filter.

Signed-off-by: Fatih Acar <fatih@opsmill.com>
By not running a subquery for each row. This should improve scaling this
query when node count grows.

Signed-off-by: Fatih Acar <fatih@opsmill.com>
We can filter out relationship constraints by node uuids.

Signed-off-by: Fatih Acar <fatih@opsmill.com>
@fatih-acar fatih-acar force-pushed the fac-stable-query-improv branch from 80a9f4a to 6c11f25 Compare January 31, 2025 23:47
@fatih-acar fatih-acar marked this pull request as ready for review February 1, 2025 00:02
Copy link
Contributor

@ajtmccarty ajtmccarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outstanding work

@fatih-acar fatih-acar force-pushed the fac-stable-query-improv branch from a9c68a0 to f002cd2 Compare February 3, 2025 12:44
@fatih-acar fatih-acar merged commit 445b2b5 into stable Feb 3, 2025
35 checks passed
@fatih-acar fatih-acar deleted the fac-stable-query-improv branch February 3, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants