Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update diff logic to handle schema kind migration #5634

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Jan 31, 2025

IFC-990

updating a schema's kind puts the database into an unusual state that the diff was not capable of handling.
the green node has the updated kind and the red node has the old kind. they both have the same UUID and the red one has been deleted. this make sense logically, but the diff expected every UUID to link to one and only one node. it also expected that there would only ever be 2 nodes connected to a relationship, not 3
image

I made some changes to the diff cypher queries and the DiffQueryParser that reads those cypher queries to allow them to handle this unusual database situation correctly

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jan 31, 2025
@ajtmccarty ajtmccarty marked this pull request as ready for review January 31, 2025 01:59
@ajtmccarty ajtmccarty requested a review from a team January 31, 2025 01:59
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #5634 will not alter performance

Comparing ajtm-01302025-diff-support-kind-migration (b2ba0f9) with stable (c5e8e73)

Summary

✅ 11 untouched benchmarks

@ajtmccarty ajtmccarty merged commit be13145 into stable Jan 31, 2025
32 checks passed
@ajtmccarty ajtmccarty deleted the ajtm-01302025-diff-support-kind-migration branch January 31, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants