update diff logic to handle schema kind migration #5634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFC-990
updating a schema's kind puts the database into an unusual state that the diff was not capable of handling.

the green node has the updated kind and the red node has the old kind. they both have the same UUID and the red one has been deleted. this make sense logically, but the diff expected every UUID to link to one and only one node. it also expected that there would only ever be 2 nodes connected to a relationship, not 3
I made some changes to the diff cypher queries and the
DiffQueryParser
that reads those cypher queries to allow them to handle this unusual database situation correctly