skip profile schemas when checking for schema migrations #5446
Conversation
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5446 will improve performances by 28.28%Comparing Summary
Benchmarks breakdown
|
|
It would be good to also remove extra |
oh nice find. removed it |
| @@ -32,11 +32,14 @@ async def schema_validate_migrations(message: SchemaValidateMigrationData) -> li | |||
| log.info(f"{len(message.constraints)} constraint(s) to validate") | |||
| # NOTE this task is a good candidate to add a progress bar | |||
| for constraint in message.constraints: | |||
| schema = message.schema_branch.get(name=constraint.path.schema_kind) | |||
| if isinstance(schema, ProfileSchema): | |||
| continue | |||
There was a problem hiding this comment.
A thought could be to reverse this by saying that what we want to have is a GenericSchema or a NodeSchema. I'm mostly thinking about a future scenario if we introduce some other type of schema SomethingElseSchema (I have no idea of what that might be). If we were to do that this function might be invalid again as it would catch entries that we might not want.
There was a problem hiding this comment.
great suggestion. I've made this change
ajtmccarty
force-pushed
the
ajtm-01132025-no-profile-migration
branch
from
27d7d06 to
53f5ffb
Compare
found this issue while doing some diff workflow testing locally
SchemaConstraintValidatorRequest.node_schemaonly acceptsNodeSchemaorGenericSchema, notProfileSchemaif a branch includes a new/updated profile instance (say
backbone_profileorupstream_profilefrom theinfrastructure_edge.pyscript), thenSchemaValidateMigrationData.constraintsthat is passed toschema_validate_migrationswill include profile schema, which will raise a validation error and break the pipelineI think the typing on
SchemaConstraintValidatorRequestis correct b/c a profile will not require a migration. We have complete control over those schema, so there should be nothing to validate