Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS errors on *.svg imports #5429

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix TS errors on *.svg imports #5429

merged 1 commit into from
Jan 10, 2025

Conversation

bilalabbad
Copy link
Contributor

@bilalabbad bilalabbad commented Jan 10, 2025

  1. Replaced @svgr/rollup by vite-plugin-svgr
  2. typed with /// <reference types="vite-plugin-svgr/client" />
  3. import as svg path with *.svg(default)
    3 bis. import as component with *.svg?react

@bilalabbad bilalabbad added group/frontend Issue related to the frontend (React) type/housekeeping Maintenance task labels Jan 10, 2025
@bilalabbad bilalabbad self-assigned this Jan 10, 2025
@bilalabbad bilalabbad requested a review from pa-lem January 10, 2025 11:28
@bilalabbad bilalabbad changed the title Fix TS errors on *.svg import Fix TS errors on *.svg imports Jan 10, 2025
@bilalabbad bilalabbad merged commit 71c3fb6 into stable Jan 10, 2025
34 checks passed
@bilalabbad bilalabbad deleted the bab-fix-svg-ts-types branch January 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/frontend Issue related to the frontend (React) type/housekeeping Maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants