Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for public url #5404

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add setting for public url #5404

merged 1 commit into from
Jan 8, 2025

Conversation

ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Jan 8, 2025

This PR just renames a setting that was previously used for local development because Infrahub would be exposed on a different port compared to the frontend app. It turns out that it can be required for SSO depending on how the infrastructure is configured and accessed. The PR only promotes a development setting and makes it public.

Fixes #5306

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #5404 will improve performances by 35.14%

Comparing pog-public-url-IFC-1029 (fd8102a) with stable (929df94)

Summary

⚡ 1 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark stable pog-public-url-IFC-1029 Change
test_schemabranch_duplicate 443.6 µs 328.3 µs +35.14%

@ogenstad ogenstad marked this pull request as ready for review January 8, 2025 15:50
@ogenstad ogenstad requested a review from a team January 8, 2025 15:50
Copy link
Contributor

@lykinsbd lykinsbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@lykinsbd lykinsbd merged commit 2294bf4 into stable Jan 8, 2025
31 checks passed
@lykinsbd lykinsbd deleted the pog-public-url-IFC-1029 branch January 8, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Be able to configure the SSO Callback in HTTPS
3 participants