fix(backend): startup optimizations #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can avoid an extra generate_object_types() call by running get_gql_query() earlier. Signed-off-by: Fatih Acar <fatih@opsmill.com>
github-actions
bot
added
the
group/backend
fatih-acar
force-pushed
the
fac-faster-startup
branch
from
4e4229c to
dd63b2b
Compare
There is a few microseconds overhead for this function... Also add a span for Query.execute in order to know the overhead of fetching the results. Signed-off-by: Fatih Acar <fatih@opsmill.com>
fatih-acar
force-pushed
the
fac-faster-startup
branch
from
dd63b2b to
e3877a7
Compare
CodSpeed Performance ReportMerging #5401 will improve performances by 36.04%Comparing Summary
Benchmarks breakdown
|
ogenstad
reviewed
Jan 8, 2025
fatih-acar
force-pushed
the
fac-faster-startup
branch
from
e3877a7 to
6a4838e
Compare
dgarros
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a ~50% speed improvement on the "regular" startup of Infrahub (no first time initialization/bootstrap).
Not really sure how to tackle the pagination issue described in e3877a7