Set PREFECT_API_URL correctly during tests #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
LucasG0
force-pushed
the
lgu-fix-test-prefect-server
branch
from
e07159a to
e4f97d6
Compare
CodSpeed Performance ReportMerging #5379 will not alter performanceComparing Summary
|
|
LGTM, but we're getting some scope mismatch on the fixtures so perhaps we need additional fixtures named after the scope. |
LucasG0
force-pushed
the
lgu-fix-test-prefect-server
branch
from
e4f97d6 to
cd4e0a7
Compare
LucasG0
force-pushed
the
lgu-fix-test-prefect-server
branch
from
cd4e0a7 to
0378e33
Compare
ogenstad
reviewed
Jan 17, 2025
|
|
||
| container.start() | ||
| wait_for_logs(container, "Configure Prefect to communicate with the server") | ||
| request.addfinalizer(cleanup) |
There was a problem hiding this comment.
Does the request.addfinalizer work in the same way when this function isn't a fixture? I'm not sure just wondering if the fixture decorator adds anything around this or if it's managed through the request object itself?
There was a problem hiding this comment.
I guess fixture decorator checks request object state when fixture function scope ends. So whereever we are mutating this object should not matter
ogenstad
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid running into
RuntimeError: Timed out while attempting to connect to ephemeral Prefect API server.while testing locally.