Extend InfrahubTask query to return multiple related nodes #5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5378 will not alter performanceComparing Summary
|
dgarros
force-pushed
the
dga-20250106-task-related-nodes
branch
from
3dab87a to
bf2fe17
Compare
ajtmccarty
approved these changes
Jan 6, 2025
ogenstad
approved these changes
Jan 7, 2025
| @@ -28,9 +28,21 @@ class Task(ObjectType): | |||
| start_time = String(required=False) | |||
|
|
|||
|
|
|||
| class TaskRelatedNode(ObjectType): | |||
| id = String(required=False) | |||
| kind = String(required=False) | |||
There was a problem hiding this comment.
Shouldn't both of these be required=True? I.e. either we'd have an empty list or the entries of that list would have values for both of these if requested?
dgarros
force-pushed
the
dga-20250106-task-related-nodes
branch
from
bf2fe17 to
9644918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extend the current
InfrahubTaskto support multiple related nodes. For historic reason the current Object only support one related node but since the migration to prefect, the backend support multiple nodes.