Validate uniqueness_constraint using NodeGetList #5361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
LucasG0
force-pushed
the
dga-20250103-uniqueness
branch
from
28fa739 to
ec62e99
Compare
CodSpeed Performance ReportMerging #5361 will not alter performanceComparing Summary
|
LucasG0
force-pushed
the
dga-20250103-uniqueness
branch
from
ec62e99 to
9e285dc
Compare
LucasG0
force-pushed
the
dga-20250103-uniqueness
branch
from
9e285dc to
d9dbb1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
NodeGetListQueryinstead ofNodeUniquenessAttributeConstraintQueryto validateuniqueness_constraintduring object mutation. This should be more efficient asNodeUniquenessAttributeConstraintQueryneeds to find violations between all nodes in db, while only nodes violating created/update node matter.