Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): remove task worker shared storage #5108

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(docker): remove task worker shared storage #5108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion development/docker-compose.local-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,4 @@ services:
task-worker:
volumes:
- ../:/source
- "git_data:/opt/infrahub/git"
- "git_remote_data:/remote"
2 changes: 0 additions & 2 deletions development/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,12 @@ services:
INFRAHUB_DB_PROTOCOL: bolt
INFRAHUB_STORAGE_DRIVER: local
volumes:
- "git_data:/opt/infrahub/git"
- "git_remote_data:/remote"
tty: true
labels:
com.github.run_id: "${GITHUB_RUN_ID:-unknown}"
com.github.job: "${JOB_NAME:-unknown}"

volumes:
git_data:
git_remote_data:
storage_data:
5 changes: 0 additions & 5 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,16 +268,11 @@ services:
INFRAHUB_TIMEOUT: ${INFRAHUB_TIMEOUT:-60}
INFRAHUB_WORKFLOW_PORT: ${INFRAHUB_WORKFLOW_PORT:-4200}
PREFECT_API_URL: http://${INFRAHUB_WORKFLOW_ADDRESS:-task-manager}:${INFRAHUB_WORKFLOW_PORT:-4200}/api
volumes:
- "git_data:/opt/infrahub/git"
- "git_remote_data:/remote"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep git_remote_data:/remote

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This volume is used for the e2e tests, when we import the git repository using docker cp.

I don't think this is used in end-user workflows?

tty: true

volumes:
database_data:
database_logs:
git_data:
git_remote_data:
storage_data:
workflow_db:
workflow_data:
1 change: 0 additions & 1 deletion tasks/shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ class Namespace(str, Enum):
VOLUME_NAMES = [
"database_data",
"database_logs",
"git_data",
"git_remote_data",
"workflow_data",
"workflow_db",
Expand Down
Loading