Check perm the same way everywhere #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
gmazoyer
force-pushed
the
gma-20241122-perm-lookup
branch
from
3ac5ac3 to
625ad4a
Compare
CodSpeed Performance ReportMerging #5024 will not alter performanceComparing Summary
|
ajtmccarty
reviewed
Nov 22, 2024
gmazoyer
force-pushed
the
gma-20241122-perm-lookup
branch
from
e93c8a7 to
cb4439f
Compare
dgarros
reviewed
Nov 25, 2024
gmazoyer
force-pushed
the
gma-20241122-perm-lookup
branch
2 times, most recently
from
3daac43 to
ad43500
Compare
gmazoyer
force-pushed
the
gma-20241122-perm-lookup
branch
from
ad43500 to
b2cffdb
Compare
ogenstad
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When permissions are checked for a given action, as soon as a backend tells that the permission is granted, other backends do not need to be queried.