Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce permission edit_default_branch when loading schema #4959

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

dgarros
Copy link
Collaborator

@dgarros dgarros commented Nov 16, 2024

Fixes #4958

I also took the opportunity to return 401 for anonymous users that are trying to make some changes instead of 403

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Nov 16, 2024
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #4959 will not alter performance

Comparing dga-20241116-fix-4958 (9cf814f) with stable (68d105f)

Summary

✅ 10 untouched benchmarks

@dgarros dgarros requested a review from a team November 16, 2024 23:53
@dgarros dgarros marked this pull request as ready for review November 16, 2024 23:53
@dgarros dgarros merged commit 7e5837f into stable Nov 17, 2024
28 checks passed
@dgarros dgarros deleted the dga-20241116-fix-4958 branch November 17, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants