Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-adding the id attribute and updated the note #4846

Merged
merged 2 commits into from
Nov 14, 2024
Merged

re-adding the id attribute and updated the note #4846

merged 2 commits into from
Nov 14, 2024

Conversation

vsurresh
Copy link
Contributor

@vsurresh vsurresh commented Nov 4, 2024

No description provided.

@vsurresh vsurresh self-assigned this Nov 4, 2024
@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Nov 4, 2024
@vsurresh
Copy link
Contributor Author

vsurresh commented Nov 4, 2024

CF page - https://sur-04112024-docs.infrahub.pages.dev/guides/create-schema#4-improving-our-schema

@vsurresh vsurresh requested a review from wvandeun November 4, 2024 20:25
@vsurresh
Copy link
Contributor Author

vsurresh commented Nov 6, 2024

@wvandeun Do we need any change here?

wvandeun
wvandeun approved these changes Nov 7, 2024
View reviewed changes
@BeArchiTek BeArchiTek merged commit bf49861 into stable Nov 14, 2024
27 checks passed
@BeArchiTek BeArchiTek deleted the sur-04112024-docs branch November 14, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeArchiTek BeArchiTek BeArchiTek approved these changes

@wvandeun wvandeun wvandeun approved these changes

Assignees

@vsurresh vsurresh

Labels
type/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsurresh @BeArchiTek @wvandeun