Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stable parameter from installation guide #4608

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

BaptisteGi
Copy link
Contributor

@BaptisteGi BaptisteGi commented Oct 11, 2024

We recently introduced changes to docker compose file. This was creating a discrepancy between the docker file (on develop branch) and the demo docker images (on stable). Thus the command invoke demo.start wasn't working anymore from develop branch. This has been solved with the newest release.

@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Oct 11, 2024
Copy link
Contributor

@wvandeun wvandeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add a bit more context information in the PR to explain why we are doing this.

@BaptisteGi BaptisteGi merged commit 80bba63 into stable Oct 11, 2024
24 checks passed
@BaptisteGi BaptisteGi deleted the bgi-rollback-stable-installation-command branch October 11, 2024 13:07
wvandeun pushed a commit to vsurresh/infrahub that referenced this pull request Oct 27, 2024
We recently introduced changes to docker compose file. This was creating a discrepancy between the docker file (on develop branch) and the demo docker images (on stable). Thus the command invoke demo.start wasn't working anymore from develop branch. This has been solved with the newest release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants