Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use elementId() instead of ID() for neo4j queries #4377

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Sep 18, 2024

fixes #4347
IFC-699

replace ID() cypher function with elementId() when the database is Neo4j
Memgraph queries will continue using ID()

also had to make some changes to how we convert a str database ID to an integer ID to account for neo4j IDs always being strings and Memgraph IDs always being ints now

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Sep 18, 2024
@ajtmccarty ajtmccarty marked this pull request as ready for review September 19, 2024 01:40
@ajtmccarty ajtmccarty requested a review from a team September 19, 2024 01:40
@dgarros dgarros merged commit db97e50 into stable Sep 19, 2024
45 checks passed
@dgarros dgarros deleted the ajtm-09182024-cypher-id-function-IFC-699 branch September 19, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants