Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pytest plugin integration tests #4367

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

wvandeun
Copy link
Contributor

Fixes an issue when using the resource testing framework integration tests in Infrahub.
Integration tests were unable to run because we were not properly setting the api_token configuration setting for the SDK.

Fixes another potential issue where some provided configuration settings could be ignored, when a specific set of configuration options were being set together.

@wvandeun wvandeun force-pushed the wvd-20240918-fix-pytest-plugin branch from 60dbde1 to a397132 Compare September 18, 2024 10:05
Copy link
Collaborator

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, would be good to target stable in order to have the fix in 0.16.1

@wvandeun wvandeun force-pushed the wvd-20240918-fix-pytest-plugin branch from a397132 to 0472ae4 Compare September 18, 2024 12:04
@wvandeun wvandeun changed the base branch from develop to stable September 18, 2024 12:05
@wvandeun wvandeun merged commit dca78d9 into stable Sep 18, 2024
2 checks passed
@wvandeun wvandeun deleted the wvd-20240918-fix-pytest-plugin branch September 18, 2024 12:09
dgarros added a commit to opsmill/infrahub-sdk-python that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants