Add ability to construct HFIDs from payload for upsert mutations #4339
+147
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
group/backend
ogenstad
force-pushed
the
pog-construct-upsert-hfid-IFC-567
branch
3 times, most recently
from
4abbc06 to
f19d60a
Compare
ajtmccarty
reviewed
Sep 16, 2024
|
|
||
| hfid: list[str] = [] | ||
| for component in node_schema.human_friendly_id: | ||
| name, hfid_value = component.split("__", maxsplit=1) |
There was a problem hiding this comment.
you could use node_schema.parse_schema_path here to get a SchemaAttributePath that includes the relationship schema, related schema, attribute_schema, and attribute_property_name
There was a problem hiding this comment.
I've added this and also removed the initial data.get(). All good with the changes now?
ajtmccarty
approved these changes
Sep 17, 2024
ogenstad
force-pushed
the
pog-construct-upsert-hfid-IFC-567
branch
from
f19d60a to
573efc2
Compare
ogenstad
force-pushed
the
pog-construct-upsert-hfid-IFC-567
branch
from
573efc2 to
7a23193
Compare
ajtmccarty
approved these changes
Sep 18, 2024
dgarros
added a commit
to opsmill/infrahub-sdk-python
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the
MutationNodeGetterByHfidclass so that it attempts to construct an HFID based on the payload of the mutation. This is done by looking at how the HFID for the object should be constructed and then see if we have enough information within the payload to create an HFID.I've not looked too closely at the HFIDs before the implementation here is done with the assumption that there are two kinds of HFID components
name__valuedevice__name__valueI've also changed the SDK so that it doesn't attempt to send in hfid if any of the fields are missing. The current behaviour was to convert the
Nonevalue into the string "None". I don't know if there is a scenario where we actually want part of the htid to be the string "None", but that part seems wrong.Fixes opsmill/infrahub-sdk-python#45