Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFC-564 - Pre populates parent field in relationships #4320

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

pa-lem
Copy link
Contributor

@pa-lem pa-lem commented Sep 10, 2024

  • The parent select is pre-filled in edit form to get the parent of the current relationship selected

@pa-lem pa-lem added type/feature New feature or request group/frontend Issue related to the frontend (React) labels Sep 10, 2024
Base automatically changed from release-0.16 to stable September 11, 2024 21:45
@pa-lem pa-lem requested a review from bilalabbad September 12, 2024 07:28
import { gql } from "@apollo/client";

const getGenericParentRelationship = (kind?: string) => {
if (!kind) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in both these function, checking kind presence is better to do outside of it (before calling the function)

Copy link
Contributor

@bilalabbad bilalabbad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other lgtm

@pa-lem pa-lem merged commit 9ecc426 into stable Sep 12, 2024
34 of 35 checks passed
@pa-lem pa-lem deleted the ple-IFC-564-parent-edit-form branch September 12, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/frontend Issue related to the frontend (React) type/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants