Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes git clone command in installation guide #4171

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

wvandeun
Copy link
Contributor

Updates the git clone command in the installation guide to use HTTPS.
Users that don't have their SSH client configured properly will run into a failure when using git over ssh.

Also removed the "." at the end of the command. It implies you have created a directory yourself that is empty, if not git will refuse to clone the repository. This is confusing to people who are not that familiar wit git.

@wvandeun wvandeun added type/documentation Improvements or additions to documentation ci/skip-changelog Don't include this PR in the changelog labels Aug 23, 2024
@wvandeun wvandeun self-assigned this Aug 23, 2024
@petercrocker
Copy link
Contributor

Tested the command, ltgm!

Copy link
Contributor

@petercrocker petercrocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm!

@wvandeun wvandeun merged commit 48be763 into stable Aug 23, 2024
36 checks passed
@wvandeun wvandeun deleted the wvd-20240823-fix-installation-guide branch August 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-changelog Don't include this PR in the changelog type/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants