better id cell

opsmill · Feb 17, 2025 · de98ea1 · de98ea1
1 parent 35bd505
commit de98ea1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/frontend/app/src/entities/nodes/object/ui/object-table/cells/table-row-identifier.tsx b/frontend/app/src/entities/nodes/object/ui/object-table/cells/table-row-identifier.tsx
@@ -11,12 +11,12 @@ export interface TableRowIdentifierProps {
 export function TableRowIdentifier({ objectKind, objectId, identifier }: TableRowIdentifierProps) {
   const display = Array.isArray(identifier) ? identifier.join(", ") : identifier;
   return (
-    <TableCell className="sticky left-0 bg-white">
+    <TableCell className="sticky left-0 bg-white px-1">
       <LinkButton
         variant="ghost"
         size="sm"
         to={getObjectDetailsUrl2(objectKind, objectId)}
-        className="underline truncate rounded-full text-custom-blue-700 hover:bg-custom-blue-700/10"
+        className="truncate px-2.5 rounded-full text-custom-blue-700 hover:underline hover:bg-custom-blue-700/10"
       >
         {display}
       </LinkButton>

diff --git a/frontend/app/src/entities/nodes/object/ui/object-table/get-object-table-columns.tsx b/frontend/app/src/entities/nodes/object/ui/object-table/get-object-table-columns.tsx
@@ -32,7 +32,11 @@ export const getObjectTableColumns = (
   return [
     {
       id: "id",
-      accessorFn: (row) => row.hfid ?? row.display_label ?? row.id,
+      accessorFn: ({ hfid, display_label, id }): string => {
+        if (schema.human_friendly_id && hfid) return hfid;
+        if (schema.display_labels && display_label) return display_label;
+        return id;
+      },
       header: () => (
         <div className={classNames(cellsStyle, cellHeaderStyle, "left-0 z-10 hover:bg-white")}>
           {schema.icon && <Icon icon={schema.icon} className="text-stone-400" />}