Fix performance issue for count queries

Fixes #4454
opsmill · Sep 25, 2024 · 4641863 · 4641863
1 parent b4ee01b
commit 4641863
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/backend/infrahub/graphql/types/mixin.py b/backend/infrahub/graphql/types/mixin.py
@@ -51,20 +51,22 @@ async def get_paginated_list(cls, fields: dict, context: GraphqlContext, **kwarg
             edges = fields.get("edges", {})
             node_fields = edges.get("node", {})
 
-            objs = await NodeManager.query(
-                db=db,
-                schema=cls._meta.schema,
-                filters=filters or None,
-                fields=node_fields,
-                at=context.at,
-                branch=context.branch,
-                limit=limit,
-                offset=offset,
-                account=context.account_session,
-                include_source=True,
-                include_owner=True,
-                partial_match=partial_match,
-            )
+            objs = []
+            if edges or "hfid" in filters:
+                objs = await NodeManager.query(
+                    db=db,
+                    schema=cls._meta.schema,
+                    filters=filters or None,
+                    fields=node_fields,
+                    at=context.at,
+                    branch=context.branch,
+                    limit=limit,
+                    offset=offset,
+                    account=context.account_session,
+                    include_source=True,
+                    include_owner=True,
+                    partial_match=partial_match,
+                )
 
             if "count" in fields:
                 if filters.get("hfid"):

diff --git a/changelog/4454.fixed.md b/changelog/4454.fixed.md
@@ -0,0 +1 @@
+Fix performance issue for GraphQL queries that only count nodes.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix performance issue for GraphQL queries that only count nodes.