Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build for python 3.13 #287

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

fatih-acar
Copy link
Contributor

@fatih-acar fatih-acar commented Feb 27, 2025

#256 was supposed to reintroduce 3.13 support, but according to CI logs:

image

Edit: need to investigate why poetry install is 20x slower with 3.13...

Signed-off-by: Fatih Acar <fatih@opsmill.com>
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@                Coverage Diff                @@
##           infrahub-develop     #287   +/-   ##
=================================================
  Coverage             70.53%   70.53%           
=================================================
  Files                    81       81           
  Lines                  7561     7561           
  Branches               1469     1469           
=================================================
  Hits                   5333     5333           
  Misses                 1849     1849           
  Partials                379      379           
Flag Coverage Δ
integration-tests 22.27% <ø> (ø)
python-3.10 45.62% <ø> (ø)
python-3.11 45.62% <ø> (+0.02%) ⬆️
python-3.12 45.62% <ø> (ø)
python-3.13 45.60% <ø> (ø)
python-3.9 44.43% <ø> (-0.03%) ⬇️
python-filler-3.12 24.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ogenstad ogenstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but based on that screenshot it seems like we also need to end with a test that validates that the running Python version is the one that we expect. :/ Without that I don't see how we could trust these tests.

@fatih-acar fatih-acar merged commit 49486cb into infrahub-develop Feb 28, 2025
14 checks passed
@fatih-acar fatih-acar deleted the fac-fix-python3.13 branch February 28, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants