Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctl: Transform to not dump to JSON string if the return of the transform is text. #283

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

FragmentedPacket
Copy link
Contributor

If the transform returns a string, do not dump to a JSON string.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/cli_commands.py 33.33% 1 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##           stable     #283      +/-   ##
==========================================
- Coverage   70.33%   70.32%   -0.02%     
==========================================
  Files          81       81              
  Lines        7505     7507       +2     
  Branches     1463     1464       +1     
==========================================
  Hits         5279     5279              
- Misses       1845     1846       +1     
- Partials      381      382       +1     
Flag Coverage Δ
integration-tests 22.43% <0.00%> (-0.01%) ⬇️
python-3.10 45.49% <33.33%> (-0.02%) ⬇️
python-3.11 45.49% <33.33%> (-0.02%) ⬇️
python-3.12 45.49% <33.33%> (-0.02%) ⬇️
python-3.9 44.31% <0.00%> (-0.02%) ⬇️
python-filler-3.12 23.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/cli_commands.py 58.13% <33.33%> (-0.46%) ⬇️

Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please can you add a newsfragment to include something in the release note

@FragmentedPacket FragmentedPacket merged commit 7861454 into stable Feb 25, 2025
14 checks passed
@FragmentedPacket FragmentedPacket deleted the may-202502-ctl-transform-allow-string-output branch February 25, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants